Code

Fix resource leak in Maven plugin#571

Code

Merged

nedtwigg merged 11 commits intodiffplug:masterdiffplug/spotless:masterfrom

lutovich:fix-mvn-resource-usagelutovich/spotless:fix-mvn-resource-usageCopy head branch name to clipboard

Jun 29, 2020

Commits

Commits on Jun 27, 2020

• NPM formatters changed to have their signatures based on package.json file instead of the

  Show description for b695622
  

  lutovich

  authored and

  nedtwigg

  committed
  b695622

  Copy full SHA for b695622

• Fix resource leak in Maven plugin

  Show description for 823c2c3
  

  lutovich

  authored and

  nedtwigg

  committed
  823c2c3

  Copy full SHA for 823c2c3

• Use a central cache for the FileSignature, so that we keep the local performance based on lastModified that we had prior to this PR.

  nedtwigg

  committed
  e4db705

  Copy full SHA for e4db705

• No need for the FileSignature cache to store multiple versions per-file, once a file has changed, we can discard the old one.

  nedtwigg

  committed
  e872905

  Copy full SHA for e872905

• Add a descriptive error-message for the highly-unexpected case

  Show description for aaddff8
  nedtwigg

  committed
  aaddff8

  Copy full SHA for aaddff8

• Fix SpotbugsWarnings (and terrible file-reading typos).

  nedtwigg

  committed
  cb724e9

  Copy full SHA for cb724e9

Commits on Jun 28, 2020

• Update the changelog for lib and plugin-maven, still need to do plugin-gradle

  nedtwigg

  committed
  5ca3b18

  Copy full SHA for 5ca3b18

• Merge branch 'main' into fix-mvn-resource-usage

  nedtwigg

  committed
  267767a

  Copy full SHA for 267767a

• Update the plugin-gradle changelog (last changelog that needed updates).

  nedtwigg

  committed
  51647ab

  Copy full SHA for 51647ab

Commits on Jun 29, 2020

• Make the FileSignature internal cache `private final`.

  nedtwigg

  committed
  5bf0896

  Copy full SHA for 5bf0896

• Suppress unused warnings.

  nedtwigg

  committed
  2395492

  Copy full SHA for 2395492